Support multiple grpc dial options for agent -> server connection #153
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/S
|
I sit to implementing keepalive for the agent, and now I understand your change ;) |
pkg/agent/clientset.go
Outdated
| @@ -110,7 +110,7 @@ type ClientSetConfig struct { | |||
| AgentID string | |||
| SyncInterval time.Duration | |||
| ProbeInterval time.Duration | |||
| DialOption grpc.DialOption | |||
| DialOption []grpc.DialOption | |||
There was a problem hiding this comment.
And here? Public so requires a bit more thought.
There was a problem hiding this comment.
Should be no problem renaming this since the agent is a standalone binary and is not imported anywhere.
Jefftree
force-pushed
the
multiple-grpc-options
branch
from
822a3ab to
ba87710
Compare
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cheftako, Jefftree The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
grpc supports multiple dial options but currently agent -> server dials (cmd/agent/main.go) only supports 1 dial option as a parameter. Refactor the code to support multiple.
This might be helpful for #152
/assign @cheftako